Skip to content

Always run build-presets workflow on PRs/pushes #13243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Aug 8, 2025

The build-presets workflow currently runs only when the workflow file itself is updated. As we update docs to recommend using presets, we should run this job on all PRs.

Note that the Windows preset is currently reporting success despite failing to actually build. I'm intending to resolve that shortly as a follow-up.

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Aug 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13243

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 94c4f20 with merge base 4ce7078 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

GregoryComer added a commit that referenced this pull request Aug 8, 2025
ghstack-source-id: ac9fae7
ghstack-comment-id: 3169379934
Pull-Request: #13243
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 8, 2025
@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Aug 8, 2025
@GregoryComer GregoryComer changed the title Always run build-presets workflow on push Always run build-presets workflow Aug 8, 2025
@GregoryComer GregoryComer changed the title Always run build-presets workflow Always run build-presets workflow on pull/push Aug 8, 2025
@GregoryComer GregoryComer changed the title Always run build-presets workflow on pull/push Always run build-presets workflow on PRs/pushes Aug 8, 2025
@GregoryComer
Copy link
Member Author

Tracking issue: #12962.

@GregoryComer GregoryComer merged commit 9308d2c into main Aug 11, 2025
100 of 104 checks passed
@GregoryComer GregoryComer deleted the gh/GregoryComer/110/head branch August 11, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants